Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix redis-rb 4.6.0 deprecation warnings #572

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix: Fix redis-rb 4.6.0 deprecation warnings #572

merged 1 commit into from
Feb 7, 2022

Conversation

ixti
Copy link
Contributor

@ixti ixti commented Feb 4, 2022

Redis 4.6.0 deprecated calling commands on Redis inside #pipelined:

redis.pipelined do
  redis.get("key")
end

The above should be:

redis.pipelined do |pipeline|
  pipeline.get("key")
end

See: redis/redis-rb#1059

@ixti
fix: Fix redis-rb 4.6.0 deprecation warnings
c01208a 
Redis 4.6.0 deprecated calling commands on `Redis` inside `#pipelined`:

    redis.pipelined do
      redis.get("key")
    end

The above should be:

    redis.pipelined do |pipeline|
      pipeline.get("key")
    end

See: redis/redis-rb#1059
@grzuy
Copy link
Collaborator

grzuy commented Feb 7, 2022

Thank you very much @ixti! 👏

@grzuy grzuy merged commit d41abd7 into rack:main Feb 7, 2022
@ixti ixti deleted the ixti/fix-redis-4.6.0-warnings branch February 7, 2022 19:57
@Aesthetikx
Copy link

Is it possible to cut a release for this? ❤️

@marcocarvalho
Copy link

marcocarvalho commented Apr 12, 2022 •
edited
Loading

Hey, is it possible to cut a release for this [2]? :)

@grzuy
Copy link
Collaborator

grzuy commented Apr 14, 2022

Released in v6.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ixti @grzuy @Aesthetikx @marcocarvalho